DanielLeens commented on issue #12119: URL: https://github.com/apache/seatunnel/issues/12119#issuecomment-6415640995
Thanks @JeremyXin for volunteering and for starting with the acceptance record rather than only moving `JobMaster.init()`. I checked current `dev` (`4f5e3293740`): normal `CoordinatorService.submitJob()` still initializes `JobMaster` before inserting the pending entry, and `preApplyResources()` sizes a request from the physical plan. #12201 is an open, separate PR for preserving WAIT queue order and deferring initialization during *master recovery*; it does not settle the normal submission/admission contract in this issue. Please take the design of that remaining submission path forward here. Before an implementation PR, make three decisions explicit: (1) what a successful submit acknowledgement means after plugin/configuration errors and cluster-side save-mode work move to the job lifecycle; (2) how a lightweight demand descriptor is derived and checked against the later physical plan without silently changing the requested slots; and (3) how a durable record/version fences cancel-before-init and master failover so a late initializer cannot resurrect or double-admit a job. Keep existing `JobStatus` values, and specify upgrade/restore behavior for jobs accepted before the new record exists. Please coordinate the recovery slice with #12201's author and let #12985 consume the same admission record rather than defining a second one. A focused design update and tests for those error-timing, cancellation, replay, and 10x-backlog heap cases are the next review gate. I added the `improve`, `Zeta`, and `design` labels. I tried to assign this design task to you, but GitHub did not accept the assignment; the `help wanted` label remains so the work is visible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
