SEZ9 commented on issue #12975: URL: https://github.com/apache/seatunnel/issues/12975#issuecomment-6432003389
@SEPURI-SAI-KRISHNA thanks for measuring rather than quoting — this covers both asks. **1. Comparison and test.** The four-default, ten-pattern table is exactly what I wanted, and asserting it in the locale-switching test is the right place for it. The corrected figures (`Locale.ROOT` abbreviating `MMMM`, `EEEE`, `QQQQ` and `LLLL`, 4 of 10, versus `Locale.ENGLISH` changing 0 of 10) only strengthen the case for `Locale.ENGLISH`, and it stays consistent with what `DAYNAME`/`MONTHNAME` already do via `DateFormatSymbols.getInstance(Locale.ENGLISH)`. If the earlier 2-of-7 figure appears anywhere in the PR description or docs, please update it to the measured numbers. **2. Docs.** Good — the behaviour note under both `FORMATDATETIME` and `FROM_UNIXTIME` on the EN and ZH pages is what I was after. Nothing further from me on this item. <!-- streview-comment:2058 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
