goutamadwant commented on PR #12318:
URL: https://github.com/apache/seatunnel/pull/12318#issuecomment-6432375928
> ### [P1] Correct the DECIMAL unary-minus documentation
> The documentation states that unary minus on a DECIMAL expression produces
DOUBLE and loses exact comparison semantics. This contradicts the current
implementation, which uses `BigDecimal.negate()`, and the regression test
`comparesNegatedDecimalOperandsExactly`.
>
> Please correct these four locations:
>
> * `docs/en/transforms/sql.md`, lines 50–52
> * `docs/zh/transforms/sql.md`, lines 46–47
> * `docs/en/introduction/concepts/incompatible-changes.md`, lines 252–253
> * `docs/zh/introduction/concepts/incompatible-changes.md`, lines 208–209
>
> The documentation should state that `-decimal_col` and `-CAST('...' AS
DECIMAL(p, s))` preserve DECIMAL precision. Also remove the wording that
requires a negative sign to be placed inside the quoted string.
>
> Keep the separate warning that fractional numeric literals evaluate as
DOUBLE and may already have lost precision before comparison.
>
> Only documentation changes are needed for this finding.
done @nzw921rx pls take a re-look and lmk. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
