DanielLeens commented on PR #12042: URL: https://github.com/apache/seatunnel/pull/12042#issuecomment-6443686306
Addressed the conflict request and the follow-up review points in `2e03ae07114721f1312386cd75184a3e577f4782`. - Merged `dev` at `eb8b80400ece6b81525529c4c2ab634839f38533` without rewriting branch history. Resolved `SourceSeaTunnelTask` by retaining both upstream source-event handling (#12163) and the source-boundedness helper. - **F1:** missing flow/action/source/boundedness metadata is rejected, with regression coverage. - **F2:** added a real coordinator regression through `reportedPipelineRunning(1, true)` that completes a checkpoint using only live acknowledgements. Also extended the engine failover IT with a real idle-close handshake and a persisted checkpoint triggered after old-master shutdown, exact row preservation and cancellation completion. - The F2 call-chain audit found that preserving readiness alone was insufficient: a newly constructed coordinator had lost its closed-idle-task set. Restore now rebuilds it from the distributed FINISHED groups before checkpoint creation, preventing an acknowledgement timeout against readers that have exited. - **F3/F5/F8:** documented the precise state-based eligibility and its limits. All coordinators must remain RUNNING; a FINISHED enumerator remains ineligible. The predicate describes what it detects rather than claiming to prove the original closure reason. Failed, bounded, empty, non-source, mixed bounded/unbounded and unknown groups remain excluded. - **F4/F7:** each physical restore decision reads execution state once; source inspection uses one traversal, and readiness uses short-circuiting `allMatch`. - **F6 and observability:** updated both documentation trees and added a restore log identifying each accepted finished reader group. The all-RUNNING gate traces to #5450 and idle-reader closure to #6526. This patch changes the master-recovery path only; it does not alter configuration defaults, dependencies, connector registration or persisted checkpoint/savepoint formats. Final `spotless:apply`, `spotless:check` and the effective diff whitespace check passed. Independent static maintainer review passed after correcting its findings. Java compilation, unit tests and the new integration test were not run locally under the active SeaTunnel policy, so runtime validation remains pending current-head GitHub CI. The prior Build check links to cancelled fork run `36327880735`, attempt 2; that old result is not validation of this commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
