SEZ9 commented on issue #13004:
URL: https://github.com/apache/seatunnel/issues/13004#issuecomment-6460732765
Thanks for the detailed proposal, the before/after example makes the gap
clear.
One thing I'd like to see spelled out: how conflicts are resolved when the
same variable is supplied more than once, e.g. in the `variables` query
parameter and in a JSON body's top-level `variables` object, or in
`params.variables` and a per-job `variables` object for `/submit-jobs`. Which
one wins, or is that treated as a duplicate key and rejected with 400?
For #13005, it would be good if the tests cover quoted values containing
commas, the `/submit-job/upload` path, and the intentional restrictions (no
fallback to system properties/environment variables, no `include` from
`[...]`/`{...}` values). I'll take a look at the PR.
<!-- streview-comment:2097 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
