nzw921rx opened a new pull request, #13028:
URL: https://github.com/apache/seatunnel/pull/13028

   ### Purpose of this pull request
   
   Fix the flaky `RestApiHttpsForTruststoreTest` startup failure observed in 
[this CI 
run](https://github.com/goutamadwant/seatunnel/actions/runs/40447940125/job/122059411945).
   
   The fixed HTTPS port `18443` can fall inside Hazelcast's randomly allocated 
discovery range. Hazelcast then connects to the HTTPS listener, reports 
`Unknown protocol`, and eventually fails to start. Allocate both REST ports 
through the existing `TestUtils` allocator so they cannot overlap the Hazelcast 
range, and remove the redundant local port helper.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. This change only updates the test fixture.
   
   ### How was this patch tested?
   
   - JDK 17: Spotless and 12 tests across `TestUtilsTest`, `RestApiHttpsTest`, 
and `RestApiHttpsForTruststoreTest` passed:
   
     ```bash
     ./mvnw -o -nsu -pl seatunnel-engine/seatunnel-engine-server 
-Dmaven.gitcommitid.skip=true spotless:apply test 
-Dtest=RestApiHttpsForTruststoreTest,RestApiHttpsTest,TestUtilsTest 
-DfailIfNoTests=false
     ```
   
   - Repeated the four Truststore tests in three additional runs; all passed:
   
     ```bash
     ./mvnw -o -nsu -pl seatunnel-engine/seatunnel-engine-server 
-Dmaven.gitcommitid.skip=true surefire:test 
-Dtest=RestApiHttpsForTruststoreTest -DfailIfNoTests=false
     ```
   
   - Temporarily forced Hazelcast's range to `18376–18475`: the original 
fixture reproduced the CI failure; the repaired fixture passed all four tests. 
Removed the temporary reproduction settings before final validation.
   - `git diff --check` passed. Maven `verify` was not run.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to