DanielLeens commented on PR #12111: URL: https://github.com/apache/seatunnel/pull/12111#issuecomment-6473876023
Thanks for the contribution. The CI fact cited in my previous conclusion has changed; this follow-up updates that gate on the unchanged reviewed head, without issuing another full source review. Gate snapshot (2026-10-28T15:57:03+00:00), head `e173c53e0299ce4e6acbe45e47349cad6a1081d2`: [Build](https://github.com/apache/seatunnel/runs/121522382401) is `FAILURE`. The blocking jobs are [Run / Dead links](https://github.com/davidzollo/seatunnel/actions/runs/40302078995/job/121502122951) `failure`; [Run / engine-v2-it (11, ubuntu-latest)](https://github.com/davidzollo/seatunnel/actions/runs/40302078995/job/121504783801) `failure`. Observed log evidence: `SplitClusterFaultToleranceIT.testStreamJobCancelResolvesWhenWorkerCrashesBeforeCancelAck:448->assertEventuallyCanceled:556 ยป ConditionTimeout` `Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.22.2:verify (default) on project connector-seatunnel-e2e-base: There are test failures.` Please inspect or rerun only the named failed job where a rerun is appropriate. The logs establish the failing stage, but do not alone establish whether the current PR caused it. No matching upstream cure has been proved by this follow-up; a base sync alone is not a verified resolution, so no unrelated module/dependency patch is requested. My [previous source conclusion](https://github.com/apache/seatunnel/pull/12111#pullrequestreview-5651252203) remains clear for the reviewed scope. CI is not being passed by inference, and this follow-up is not an effective approval. Comparison recorded in this scan: base `dev`, `diverged`, ahead 6 / behind 415, no merge conflict. Branch drift is metadata here and is not an additional sync request. My source blocker is cleared, but an older CHANGES_REQUESTED opinion may remain in the review summary after a COMMENT-only technical conclusion. With Daniel currently READ-only, a write-capable maintainer must separately reconcile the effective approval/dismissal gate; this clarification does not claim that action was performed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
