This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new 26d0936b81 [Fix][Connector-V2] Stop emitting a Databend TIME column
type (#13040)
26d0936b81 is described below
commit 26d0936b81a7861d5e35c51d9d19a2ccafd29a37
Author: Sepuri Sai Krishna <[email protected]>
AuthorDate: Thu Oct 29 17:49:03 2026 +0000
[Fix][Connector-V2] Stop emitting a Databend TIME column type (#13040)
---
docs/en/connectors/source/Databend.md | 1 -
docs/zh/connectors/source/Databend.md | 1 -
.../databend/util/DatabendTypeConverter.java | 9 ++-
.../databend/util/DatabendTypeConverterTest.java | 85 ++++++++++++++++++++++
.../e2e/connector/databend/DatabendIT.java | 37 ++++++++++
5 files changed, 130 insertions(+), 3 deletions(-)
diff --git a/docs/en/connectors/source/Databend.md
b/docs/en/connectors/source/Databend.md
index ef992a01ad..b133fd52c9 100644
--- a/docs/en/connectors/source/Databend.md
+++ b/docs/en/connectors/source/Databend.md
@@ -66,7 +66,6 @@ They can be downloaded via install-plugin.sh or from the
Maven central repositor
| CHAR | STRING |
| TIMESTAMP | TIMESTAMP |
| DATE | DATE |
-| TIME | TIME |
| BINARY | BYTES |
## Source Options
diff --git a/docs/zh/connectors/source/Databend.md
b/docs/zh/connectors/source/Databend.md
index 023459cde5..d26360c009 100644
--- a/docs/zh/connectors/source/Databend.md
+++ b/docs/zh/connectors/source/Databend.md
@@ -62,7 +62,6 @@ SQL 语句。连接器在批处理模式下执行查询，并把每一行结果
| CHAR | STRING |
| TIMESTAMP | TIMESTAMP |
| DATE | DATE |
-| TIME | TIME |
| BINARY | BYTES |
## 源选项
diff --git
a/seatunnel-connectors-v2/connector-databend/src/main/java/org/apache/seatunnel/connectors/seatunnel/databend/util/DatabendTypeConverter.java
b/seatunnel-connectors-v2/connector-databend/src/main/java/org/apache/seatunnel/connectors/seatunnel/databend/util/DatabendTypeConverter.java
index 221259a4ae..e3097022b9 100644
---
a/seatunnel-connectors-v2/connector-databend/src/main/java/org/apache/seatunnel/connectors/seatunnel/databend/util/DatabendTypeConverter.java
+++
b/seatunnel-connectors-v2/connector-databend/src/main/java/org/apache/seatunnel/connectors/seatunnel/databend/util/DatabendTypeConverter.java
@@ -68,7 +68,14 @@ public class DatabendTypeConverter {
case DATE:
return "DATE";
case TIME:
- return "TIME";
+ // Databend has no TIME type. Its type parser accepts TIME
only inside
+ // TIMESTAMP WITH TIME ZONE, so an ALTER TABLE ADD COLUMN
naming TIME fails to
+ // parse and the schema change event is rejected. A time of
day is carried as
+ // text instead, which is what the Doris and StarRocks
converters also do for a
+ // target without a TIME type. Those two use VARCHAR(8);
STRING is used here
+ // because LocalTime.toString() reaches 18 characters once the
value carries a
+ // sub-second part, and Databend's String is unbounded.
+ return "STRING";
case TIMESTAMP:
return "TIMESTAMP";
case BYTES:
diff --git
a/seatunnel-connectors-v2/connector-databend/src/test/java/org/apache/seatunnel/connectors/seatunnel/databend/util/DatabendTypeConverterTest.java
b/seatunnel-connectors-v2/connector-databend/src/test/java/org/apache/seatunnel/connectors/seatunnel/databend/util/DatabendTypeConverterTest.java
new file mode 100644
index 0000000000..43f8b9ec32
--- /dev/null
+++
b/seatunnel-connectors-v2/connector-databend/src/test/java/org/apache/seatunnel/connectors/seatunnel/databend/util/DatabendTypeConverterTest.java
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.databend.util;
+
+import org.apache.seatunnel.api.table.catalog.Column;
+import org.apache.seatunnel.api.table.catalog.PhysicalColumn;
+import org.apache.seatunnel.api.table.converter.BasicTypeDefine;
+import org.apache.seatunnel.api.table.type.BasicType;
+import org.apache.seatunnel.api.table.type.DecimalType;
+import org.apache.seatunnel.api.table.type.LocalTimeType;
+import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Covers the SeaTunnel to Databend type mapping used to build the ALTER TABLE
statements that carry
+ * a schema change event into Databend.
+ */
+public class DatabendTypeConverterTest {
+
+ @Test
+ public void timeIsCarriedAsTextBecauseDatabendHasNoTimeType() {
+ // Databend's type parser accepts TIME only inside TIMESTAMP WITH TIME
ZONE, so naming it
+ // as a column type produces a statement Databend cannot parse. A
MySQL CDC source turns a
+ // MySQL TIME column into LOCAL_TIME_TYPE, so this type does reach the
converter.
+ Assertions.assertEquals("STRING",
columnTypeOf(LocalTimeType.LOCAL_TIME_TYPE));
+ Assertions.assertNotEquals(
+ "TIME",
+ columnTypeOf(LocalTimeType.LOCAL_TIME_TYPE),
+ "TIME is not a type Databend can parse in a column
definition");
+ }
+
+ @Test
+ public void theOtherTemporalTypesAreUnchanged() {
+ Assertions.assertEquals("DATE",
columnTypeOf(LocalTimeType.LOCAL_DATE_TYPE));
+ Assertions.assertEquals("TIMESTAMP",
columnTypeOf(LocalTimeType.LOCAL_DATE_TIME_TYPE));
+ }
+
+ @Test
+ public void theRestOfTheMappingIsUnchanged() {
+ Assertions.assertEquals("STRING", columnTypeOf(BasicType.STRING_TYPE));
+ Assertions.assertEquals("BOOLEAN",
columnTypeOf(BasicType.BOOLEAN_TYPE));
+ Assertions.assertEquals("INT", columnTypeOf(BasicType.INT_TYPE));
+ Assertions.assertEquals("BIGINT", columnTypeOf(BasicType.LONG_TYPE));
+ Assertions.assertEquals("DECIMAL(10,2)", columnTypeOf(new
DecimalType(10, 2)));
+ }
+
+ @Test
+ public void theColumnNameAndNullabilityAreCarriedThrough() {
+ Column column =
+ PhysicalColumn.builder()
+ .name("started_at")
+ .dataType(LocalTimeType.LOCAL_TIME_TYPE)
+ .nullable(false)
+ .build();
+
+ BasicTypeDefine typeDefine =
DatabendTypeConverter.convertToDatabendType(column);
+
+ Assertions.assertEquals("started_at", typeDefine.getName());
+ Assertions.assertEquals("STRING", typeDefine.getColumnType());
+ Assertions.assertFalse(typeDefine.isNullable());
+ }
+
+ private static String columnTypeOf(SeaTunnelDataType<?> dataType) {
+ Column column =
+
PhysicalColumn.builder().name("c").dataType(dataType).nullable(true).build();
+ return
DatabendTypeConverter.convertToDatabendType(column).getColumnType();
+ }
+}
diff --git
a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-databend-e2e/src/test/java/org/apache/seatunnel/e2e/connector/databend/DatabendIT.java
b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-databend-e2e/src/test/java/org/apache/seatunnel/e2e/connector/databend/DatabendIT.java
index af149c537b..ee15f5b172 100644
---
a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-databend-e2e/src/test/java/org/apache/seatunnel/e2e/connector/databend/DatabendIT.java
+++
b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-databend-e2e/src/test/java/org/apache/seatunnel/e2e/connector/databend/DatabendIT.java
@@ -17,6 +17,10 @@
package org.apache.seatunnel.e2e.connector.databend;
+import org.apache.seatunnel.api.table.catalog.Column;
+import org.apache.seatunnel.api.table.catalog.PhysicalColumn;
+import org.apache.seatunnel.api.table.type.LocalTimeType;
+import
org.apache.seatunnel.connectors.seatunnel.databend.util.DatabendTypeConverter;
import org.apache.seatunnel.e2e.common.TestResource;
import org.apache.seatunnel.e2e.common.TestSuiteBase;
import org.apache.seatunnel.e2e.common.container.TestContainer;
@@ -26,6 +30,7 @@ import org.awaitility.Awaitility;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestTemplate;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -152,6 +157,38 @@ public class DatabendIT extends TestSuiteBase implements
TestResource {
}
}
+ /**
+ * Adds a column with the type DatabendTypeConverter gives a SeaTunnel
TIME column, which is the
+ * type the sink puts in the ALTER TABLE ADD COLUMN statement for a schema
change event that
+ * adds a TIME column. Databend has no TIME type, so the statement only
runs when the converter
+ * maps TIME to a type Databend has.
+ */
+ @Test
+ public void testTimeColumnTypeIsAcceptedByDatabend() throws SQLException {
+ Column timeColumn =
+ PhysicalColumn.builder()
+ .name("start_time")
+ .dataType(LocalTimeType.LOCAL_TIME_TYPE)
+ .nullable(true)
+ .build();
+ String columnType =
DatabendTypeConverter.convertToDatabendType(timeColumn).getColumnType();
+
+ try (Connection connection = getConnection();
+ Statement statement = connection.createStatement()) {
+ statement.execute("DROP TABLE IF EXISTS time_column_table");
+ statement.execute("CREATE TABLE time_column_table (id INT)");
+ statement.execute("ALTER TABLE time_column_table ADD COLUMN
start_time " + columnType);
+
+ List<String> columnNames = new ArrayList<>();
+ try (ResultSet resultSet = statement.executeQuery("DESC
time_column_table")) {
+ while (resultSet.next()) {
+ columnNames.add(resultSet.getString("field"));
+ }
+ }
+ Assertions.assertEquals(Arrays.asList("id", "start_time"),
columnNames);
+ }
+ }
+
@TestTemplate
public void testDatabend(TestContainer container) throws Exception {
Container.ExecResult execResult =
container.executeJob(DATABEND_JOB_CONFIG);
