PHJ2000 commented on PR #11586: URL: https://github.com/apache/seatunnel/pull/11586#issuecomment-6516447179
Hi @TFGSUMIT, following the scope discussion in #11007 (https://github.com/apache/seatunnel/issues/11007#issuecomment-6514046323), I’m planning a separate change for MaxCompute Sink `endpoint` validation. The change will add `Conditions.notBlank(ENDPOINT)` to the existing required sink option, with factory tests for valid, missing, empty, whitespace-only and padded nonblank values, matching EN/ZH documentation, and configuration-check coverage in the existing MaxCompute E2E suite. Nonblank values, retry settings and other runtime behavior will remain unchanged. Since our changes touch the same sink factory, factory tests and documentation, I’ll keep my diff focused on the endpoint rule and rebase if your PR lands first. I haven’t changed code or run tests for this slice yet. <!-- contribution-flow:apache--seatunnel--11007:maxcompute-sink-overlap-notice-v1 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
