SEZ9 commented on issue #13022: URL: https://github.com/apache/seatunnel/issues/13022#issuecomment-6552255552
@SEPURI-SAI-KRISHNA thanks, that covers both points from my last comment. 1. The `decimal(76, 10)` → `DecimalType(76, 10)` assertion in `decimalKeepsItsPrecisionAndScale` is exactly what I wanted alongside the `(10, 2)` and `(38, 0)` cases, since `DecimalType.equals` compares precision and scale a wrong value will fail there. Adding the capitalized `Decimal(10, 2)` form reported by older servers is a good addition too. 2. The comment on the DECIMAL branch stating that precision and scale come from `COLUMN_SIZE` and `DECIMAL_DIGITS` (parsed by the driver from the full `TYPE_NAME`, not from the normalized name) is enough to keep the next reader from assuming the stripped name is the source. Nothing more needed on that from my side. On the scope change: agreed. If the driver hands BINARY values back as Strings, declaring BYTES without converting the values would mislead users, so keeping BINARY as it is on `dev` and letting #13023 fix only the DECIMAL part is the right call. Please leave this issue open after #13023 merges so the BINARY part is tracked for the follow-up. I'll take another look at #13023 with these changes in place. <!-- streview-comment:2179 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
