SEZ9 commented on PR #11559: URL: https://github.com/apache/seatunnel/pull/11559#issuecomment-6552600864
Thanks for the update and the detailed sync notes on head `e7f159373393b9abfa80f479d86d4d27e1091d25`. One point from my earlier review is still open: the unsafe Java deserialization pattern in `seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceReader.java` (PR11559-F1, High, Security). The sync notes say `KafkaSourceReader` had no new `dev` changes since the previous sync; that covers the `dev` side of the merge only, and I have not yet reviewed a diff for that file on the new head, so I cannot say whether the PR's own commits changed it. Could you: - Either replace the deserialization path in `KafkaSourceReader` with a safe alternative (an explicit, schema-bound deserializer for the expected state/payload type, or an allow-list for the deserialized classes), or, if you believe the input is fully trusted and not attacker-reachable, describe the trust boundary in the PR so it can be assessed and recorded. - Point me at the commit that addresses it, or confirm whether the file is unchanged on `e7f159373393b9abfa80f479d86d4d27e1091d25` and whether the fix is intentionally deferred, so I can re-check only that file. I am not expanding scope beyond this finding here; the other points from the thread stand as already stated. <!-- streview-comment:2184 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
