SEZ9 commented on issue #12601: URL: https://github.com/apache/seatunnel/issues/12601#issuecomment-6552245185
@fatmanverse Thanks for the detailed write-up and the reproduction on `e2957d2` — the test section is clear now. Please go ahead. The plan looks good to me: - Unit tests covering the three cases of the type-name resolution (user-defined type resolved by OID, built-in names unchanged, unresolved OID failing with table, column and OID). - The ADD COLUMN E2E case that pre-creates the schema and types, adds one column per type after the snapshot, and asserts both the sink `format_type` and the row data. - Using `stringtype=unspecified` on the sink URL for that case is fine; please add a short comment in the test explaining why it is there. When you open the PR, please reference this issue and briefly restate why the fix lives on the OID-based RELATION path rather than in the `TypeRegistry` name lookups, and include the before/after sink DDL so reviewers can confirm the spelling matches the initial `CREATE TABLE`. Ping me once it's up and I'll review. <!-- streview-comment:2177 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
