DanielLeens commented on PR #12984: URL: https://github.com/apache/seatunnel/pull/12984#issuecomment-6557775437
Thanks @nzw921rx; you are right. My earlier source-clear conclusion missed this admitted-upload interleaving. I traced your point through the actual code: `SeaTunnelServer.getConnectorPackageService:469-470` checks the coordinator, then separately calls its getter; `CoordinatorService.getConnectorPackageService:2307-2312` reads the field after that check. Clearing it at :1352 can therefore turn a previously admitted operation into the misleading storage-not-configured exception. `UploadConnectorJarOperation:79-89` runs the storage call on the separate upload_connector_jar_operation executor, which is not covered by the coordinator executor's termination wait. +1 to retaining the reference while still invoking close on the captured service. The timer cancellation remains necessary; removing the null assignment is the smallest fix for this specific new race, without claiming to fence every possible failover operation. Your controlled replay is valuable reviewer-provided execution evidence; I did not run that component test locally. Please retain an entry-level regression that distinguishes this interleaving in the corrected commit. The earlier failing-CI/sync instruction is also obsolete: the current-head fork and Apache Build are now successful. That does **not** clear the source blocker you identified. I withdraw my prior source clearance until that race is fixed and re-reviewed. The branch being behind dev is recorded metadata, not an additional sync request. This replies to the new review point without duplicating it as another numbered Daniel finding. Checked 2026-11-01T12:12:56.254182+00:00; unchanged head `a5645167aa82152d823bdcefe3f0596a513ce5ac`, base `dev`; compare `diverged`, ahead 1 / behind 75; merge `blocked` / `BLOCKED`; review decision `REVIEW_REQUIRED`. Behind/diverged is recorded independently and does not itself request a sync. Daniel has READ repository permission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
