DanielLeens commented on PR #13020: URL: https://github.com/apache/seatunnel/pull/13020#issuecomment-6567902475
Thanks for the careful status write-up, and for re-checking the dispatch restriction instead of working around it with an empty commit. That is the right call. To keep the record straight from the review side: - Head `4d98b290adad` is unchanged since my last review, and that review found no remaining source issue. Nothing needs to change in the code, tests or docs. - The only open item is execution evidence: the apache-side check-runs for this SHA are empty because the fork `Build` was never created (the 422 on workflow dispatch you describe). I cannot work around that from my side either, and this is not something a rebase would fix. What I would suggest as the practical path: 1. Once Actions is accepted again on your fork, re-dispatch `Build` for this exact SHA and post the run link here. If dispatch stays blocked, a committer may be able to run the workflow for this SHA instead; I will leave that to them. 2. Until then, please leave the code as is. The padding contract, the factory-routed `HttpIT` case and the en/zh notes are all in place. No action is needed on the source side. Thanks again for the patience and the thorough follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
