SEPURI-SAI-KRISHNA commented on PR #13076:
URL: https://github.com/apache/seatunnel/pull/13076#issuecomment-6572091406
@DanielLeens thanks for the review. Issue 1 is done in the latest commit.
`JdbcMysqlIT` and `JdbcOceanBaseMysqlIT` each get
`testCatalogReadsColumnTypesUnderTurkishLocale`: it creates a table with `int`,
`int unsigned`, `bigint` and `datetime` columns, sets `tr-TR` and then `az-AZ`
in the test JVM, where the catalog runs, and reads the table through the
catalog the IT already opens. The locale is restored in `finally`.
I checked that both detect the bug, against MySQL 8.0.43 and OceanBase CE
4.4.2.1. With this PR both pass. With the four changed classes as they are on
`dev`, both fail with `COMMON-20 ...
{"c_int":"İNT","c_int_unsigned":"İNT","c_bigint":"BİGİNT","c_datetime":"DATETİME"}`,
and the locale is still restored. The existing
`testSetAndEnumColumnWithUnsignedWordInValueList` and
`testEnumColumnWithUnsignedWordInValueList` still pass. The PR description is
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
