DanielLeens commented on PR #13090: URL: https://github.com/apache/seatunnel/pull/13090#issuecomment-6574892266
Thanks for the explanation, @SEPURI-SAI-KRISHNA. That is a fair position and I agree with it for this PR. Issue 1 in my review was explicitly a Low, non-blocking, optional follow-up, so it does not need any change here. Keeping the explicit enum means each new Elasticsearch major is added together with an IT that actually runs against it (as `Elasticsearch9IT` does), and the existing `ELASTICSEARCH-02` error already reports the unsupported version, so the failure mode is easy to diagnose. Please leave the code as it is. My conclusion from the last review is unchanged for the current head `1b56d72f`: no source blockers, and the `Build` check is green. This comment is based on reading the code and the thread only; I did not run anything locally. The remaining step is a committer approval and queue action, which I cannot perform with read access. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
