SEZ9 commented on issue #13078:
URL: https://github.com/apache/seatunnel/issues/13078#issuecomment-6593639457
@SEPURI-SAI-KRISHNA thanks for the updated note. On the two open questions:
**2. Naming** — confirmed. Plugin `Jms` and module `connector-jms` are fine;
the generic name matches the goal of covering the JMS/AMQP row through the
standard javax.jms 1.1 API, and it keeps a clear separation from
`connector-activemq` / `connector-rabbitmq`, which stay as they are per your
Section 1.
**3. Jar location** — confirmed. Bundling `geronimo-jms_1.1_spec` 1.1.1
(Apache License 2.0) as the only new dependency and shipping no vendor client
is the right call, and `${SEATUNNEL_HOME}/plugins/connector-jms/` is fine as
the documented location for vendor jars. Please have the docs state which
vendor jars a user needs to place there for each provider you tested.
On the rest of the update: items 8 (commit failure after a confirmed
checkpoint), 9 (`ExceptionListener` for the `receiveNoWait()` returning `null`
case), 10 (recommending a low `prefetchPolicy.queuePrefetch`) and 11 (in-flight
bound below broker limits such as IBM MQ `MaxUncommittedMsgs`) read correctly
to me and match the "duplicates, no loss" guarantee you set out. Thanks also
for publishing the spike code and logs at
https://gist.github.com/SEPURI-SAI-KRISHNA/7aabc26904659c6a1348578d66e84e6e;
that makes the design much easier to review.
Both questions are settled, so please go ahead with slice 1 (queue source).
<!-- streview-comment:2231 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
