goutamadwant opened a new pull request, #13109:
URL: https://github.com/apache/seatunnel/pull/13109
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code
changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB
issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix
typo in README.md doc`.
-->
### Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull
request adds checkstyle plugin.-->
I'm happy to contribute this fix to SeaTunnel.
Fixes #13105. This is a separate JDBC prerequisite for #12983.
XA recovery currently matches only job/subtask ownership, so one table
writer can roll back another table writer's prepared transactions. Restore the
saved writer identities, preserve all checkpointed XIDs, and restrict cleanup
to that writer's orphaned transactions. A live rollback retry targets only the
failed transaction.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new
specifications: https://github.com/apache/seatunnel/issues/4544.
-->
A restored multi-table JDBC writer preserves its sibling's prepared
transactions. Cleanup failures now fail recovery instead of being logged as
successful cleanup. XID encoding and configuration stay compatible.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If you are adding E2E test cases, maybe refer to
https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf,
here is a good example.
-->
- Reproduced the peer-transaction rollback on dev (`3244c9504c75`) before
applying this patch.
- Passed 22 focused tests in SemanticXidGeneratorTest, XaGroupOpsImplTest
and JdbcExactlyOnceSinkWriterTest on this standalone branch. These cover
saved/peer ownership, rescaling, malformed state, repeated restore, transaction
sequences and rollback failures.
- Passed all three XaGroupOpsImplIT cases against MySQL 8.0.43 on this
standalone branch, with unmodified test methods: sibling prepared transactions
survive cleanup/repeated restore, owned orphans are removed, and
resource-manager commit failures propagate.
- Formatting passed. Full Java 11 repository verify passed with tests
skipped on the combined JDBC + Flink tree; its changed files match the two
standalone patches byte for byte. The focused/native results above were run
separately.
Focused command:
```sh
./mvnw -Pci -Dmaven.jar.forceCreation=true -pl
seatunnel-connectors-v2/connector-jdbc -am
-Dtest=SemanticXidGeneratorTest,XaGroupOpsImplTest,JdbcExactlyOnceSinkWriterTest
-Dsurefire.failIfNoSpecifiedTests=false verify
```
Native command:
```sh
./mvnw -Pci -Dmaven.jar.forceCreation=true -pl
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1
-am -DskipUT=true -DskipIT=false -Dit.test=XaGroupOpsImplIT
-Dfailsafe.failIfNoSpecifiedTests=false -DfailIfNoTests=false verify
```
Hosted CI is separate from these local results.
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
No new connector or binary package is added. Existing registration files
still apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
