Vivek1106-04 commented on PR #12623:
URL: https://github.com/apache/seatunnel/pull/12623#issuecomment-6595637819
@SEZ9 @DanielLeens
**F1.** I added a merge-order line near the top of the PR description: this
PR depends on #12511, which must land first. Please re-check F1 once #12511 is
merged.
**F2.** I ran the revert locally. I started from the unchanged head
`caa5f098f`, set `PhysicalVertex.java` back to its `dev` version (the merge
parent `caa5f098f^2`), and left the test file as it is. Then I ran
`StateTransitionCleanupTest` on JDK 17 with `./mvnw -pl
seatunnel-engine/seatunnel-engine-server -am package
-Dtest=StateTransitionCleanupTest -Dsurefire.failIfNoSpecifiedTests=false`.
With the `PhysicalVertex` change reverted, 2 of the 20 tests fail. Both are
the new `forceStop` cases, and in each the task future is never completed:
```
[ERROR] Tests run: 20, Failures: 0, Errors: 2, Skipped: 0, Time elapsed:
23.149 s <<< FAILURE! - in
org.apache.seatunnel.engine.server.dag.physical.StateTransitionCleanupTest
[ERROR] testForceStopCompletesTheFutureOfATaskWhoseStateProcessIsStopped
Time elapsed: 10.029 s <<< ERROR!
java.util.concurrent.TimeoutException
at
org.apache.seatunnel.engine.server.dag.physical.StateTransitionCleanupTest.testForceStopCompletesTheFutureOfATaskWhoseStateProcessIsStopped(StateTransitionCleanupTest.java:189)
[ERROR] testForceStopCompletesTheFutureOfATaskResetForRestore Time elapsed:
10.011 s <<< ERROR!
java.util.concurrent.TimeoutException
at
org.apache.seatunnel.engine.server.dag.physical.StateTransitionCleanupTest.testForceStopCompletesTheFutureOfATaskResetForRestore(StateTransitionCleanupTest.java:220)
```
Lines 189 and 220 are `taskFuture.get(10, TimeUnit.SECONDS)` right after
`physicalVertex.forceStop()`. The other 18 tests still pass, including the
skipped-transition case, which is expected because the PR leaves that path
unchanged.
As a control, I restored the PR's `PhysicalVertex.java` in the same worktree
and ran the same command: `Tests run: 20, Failures: 0, Errors: 0, Skipped: 0`,
`BUILD SUCCESS`.
The head is unchanged at `caa5f098f`. I have not pushed anything, since the
revert was only for this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
