JAEKWANG97 opened a new issue, #13131:
URL: https://github.com/apache/seatunnel/issues/13131

   ## Problem
   
   `AbstractMultiCatalogTransform` builds and owns per-table transforms in 
`transformMap`, but does not override `open()` or `close()`. Wrappers that 
inherit the interface defaults therefore skip their children's lifecycle 
callbacks.
   
   A resource-owning child can miss initialization or cleanup. 
`ChainedMapTransform` and `ChainedFlatMapTransform` already forward callbacks; 
the outer multi-table wrapper is the missing link.
   
   ## Expected behavior
   
   - Forward lifecycle callbacks to owned children in a normal startup/shutdown 
cycle.
   - Propagate child initialization failures and define cleanup after partial 
initialization.
   - Continue closing other children if one cleanup fails, retaining the 
original failure.
   - Preserve existing wrapper overrides, child ownership, and serialization 
compatibility. Avoid duplicate cleanup.
   
   ## Suggested validation
   
   Extend existing multi-table transform tests with recording children. Cover 
one and several tables, Map/FlatMap paths, composed rules, identity children, 
and partial failures. Check existing wrappers with custom cleanup so callbacks 
are not duplicated.
   
   Source inspection confirms the missing forwarding. These tests have not been 
run for this report.
   
   ## Scope and references
   
   This is a lifecycle prerequisite for STIP-44, independent of the provider 
contract. Existing public interfaces and static-key behavior stay compatible.
   
   - Review request: 
https://github.com/apache/seatunnel/issues/13099#issuecomment-6594148302
   - Wrapper at inspected dev commit: 
https://github.com/apache/seatunnel/blob/2eccdc412a6dce28fe0f80b5d26973737fa876d7/seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/common/AbstractMultiCatalogTransform.java
   - Default lifecycle methods: 
https://github.com/apache/seatunnel/blob/2eccdc412a6dce28fe0f80b5d26973737fa876d7/seatunnel-api/src/main/java/org/apache/seatunnel/api/transform/SeaTunnelTransform.java
   - Related adapter fix, already merged: 
https://github.com/apache/seatunnel/pull/12263
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to