SiriusTL666 commented on PR #13009: URL: https://github.com/apache/seatunnel/pull/13009#issuecomment-6623871163
One addition, since your review noted you inferred but did not confirm that the new IT actually ran: I checked the fork run for this head. The `changes` job detected both e2e files and selected the module: ``` update_files='[".../FtpFileIT.java", ".../ftp_control_timeout.conf"]' ,connector-file-ftp-e2e ``` The new case then executed in `updated-modules-integration-test-part-8`, 5 times across the engine matrix, with no failures: ``` Test ...FtpFileIT.testFtpControlTimeoutIsHonouredThroughTheJobConfig is running. [FtpFileIT#testFtpControlTimeoutIsHonouredThroughTheJobConfig] E2E test case cost 27s. Test ...FtpFileIT.testFtpControlTimeoutIsHonouredThroughTheJobConfig successfully run. ... 5x "successfully run", 0 failures ``` At 27–29 s per case against the real vsftpd container, this is a genuine job execution, so the distinct source (30000) and sink (15000) values were accepted by factory validation and carried through the real read/write path with the 5-line assertion intact. Two things worth recording for the merge decision: - The flaky `JobStateEventTest` failure I mentioned earlier was in an unrelated module. A failed-job rerun on the same head completed **fully green**, which confirms it was environmental and not caused by this change. - The Apache-side Build has since reported SUCCESS for `5c268fe1` as well, so both the fork run and the required check are green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
