DanielLeens commented on PR #13120: URL: https://github.com/apache/seatunnel/pull/13120#issuecomment-6646236120
Thanks @SEPURI-SAI-KRISHNA. A quick update on the CI note in my last review, which said the fork run was still pending. Run https://github.com/SEPURI-SAI-KRISHNA/seatunnel/actions/runs/41788934624 has now finished. The only failed job is the one I already pointed out: `unit-test (17, ubuntu-latest)`, in `connector-redis` `Redis7Test.failedInitializationClosesConnections` (`Redis7Test.java:156` -> `:169` -> `awaitCondition:268`). Every other job is green, including `unit-test (11, ubuntu-latest)`, where the four restore-path test classes of this PR ran, and both Windows lanes. That Redis test compares live connection counts from a container within a short polling window. This engine-server diff does not touch it, and it passed 14/14 on JDK 11 in the same run. `dev` has no change to it since it was added, so a `dev` sync would not help. Please use "Re-run failed jobs" on that run. No code change is needed. My conclusion is unchanged: there are no non-CI blockers, and I will approve once `Build` is green on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
