zhangshenghang commented on PR #13149:
URL: https://github.com/apache/seatunnel/pull/13149#issuecomment-6683141312

   All four issues from the latest review are fixed in 29df682da (docs only):
   
   1. **Job-id reuse remedy** (`rest-api-job-lifecycle.md`, en + zh): the 
remedy now says to submit a fresh job with a new `job.id`, or to restore 
intentionally via the documented savepoint/restore flow; nothing suggests 
deleting history or checkpoint data. The trigger cell also states that a 
cancelled job's history is retained, so cancelling alone does not free the ID.
   2. **SFTP key note** (`SftpFile.md`, en + zh): both languages now say 
passphrase-protected key files are not supported and must be decrypted before 
the job starts; the SSH-agent wording is dropped.
   3. **Jindo OSS schema** (`OssJindoFile.md`, en + zh): the `schema` row is 
marked conditional — required for `text`/`json`/`excel`/`csv`/`xml` (matching 
`OssFileSourceFactory.optionRule()`), auto-inferred for `parquet`/`orc`. The 
text/CSV walkthrough no longer shows a schema-less path: the 
single-content-column example configures that schema explicitly.
   4. **JDBC dialect list** (`Jdbc.md` source/sink, en + zh): `Inceptor` is 
removed from all four tables and that slot now lists `Presto`; a `DuckDB` row 
is added; the `dialect` note now also covers Inceptor (leave `dialect` unset or 
set it to `HIVE`, with `compatible_mode = "inceptor"`).
   
   On the overlap with #12986: the four dialect tables in this PR are now 
byte-identical to #12986's pushed text, so whichever PR merges second 
auto-resolves without a manual fix. The Kafka sink `semantics` note keeps this 
PR's wording because #12986's sentence links to a `#semantics` anchor that does 
not exist on this branch; that single blockquote line may need a one-line 
resolution if both PRs are merged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to