SEPURI-SAI-KRISHNA opened a new pull request, #13159:
URL: https://github.com/apache/seatunnel/pull/13159

   Yes, glad to contribute to Apache SeaTunnel.
   
   ### Purpose of this pull request
   
   Closes #13158.
   
   #12895 added `ContainerSelectionCondition` to the `TestSuiteBase` in 
`seatunnel-e2e-common`, so a test whose containers are all disabled is skipped. 
The transform suites extend their own `TestSuiteBase` in 
`seatunnel-transforms-v2-e2e-common`, which did not get it. They still fail 
with `PreconditionViolationException` when `RUN_ENGINES` narrows the scope. 
This PR adds the same extension there, in the same position.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. This is test infrastructure only.
   
   ### How was this patch tested?
   
   I ran the real test classes through the JUnit launcher with no containers, 
against this PR's `TestSuiteBase`, one run each:
   
   ```
                                                      dev                       
       this PR
   RUN_ENGINES=spark, TestTableFilterIT (2 tests)     
PreconditionViolationException   skipped
   RUN_ENGINES=spark, TestSQLIT.testNestedType,
     testVectorFunctions, testInnerQuery              
PreconditionViolationException   skipped
   RUN_ENGINES=flink, TestTableFilterIT (2 tests)     
PreconditionViolationException   skipped
   ```
   
   With all engines selected, the four transform jobs pass on JDK 11 and 17 in 
[this fork 
run](https://github.com/SEPURI-SAI-KRISHNA/seatunnel/actions/runs/42158635009) 
of this commit. In the JDK 11 `part-2` log, `TestSQLIT` runs 32 tests, 
`TestTableFilterIT` 2 and `TestDynamicCompileIT` 83, all with 0 errors and 0 
skipped, so nothing is skipped while an engine is left.
   
   **Not tested:**
   
   - The skip for the 6 `TestDynamicCompileIT` tests, because the class starts 
a mock server container. They use the same annotation.
   - A CI run with a narrowed scope. This PR changes 
`seatunnel-transforms-v2-e2e`, so its own CI runs all engines and cannot show 
the Spark-only case. The Spark-only failure it addresses is in [this fork 
run](https://github.com/SEPURI-SAI-KRISHNA/seatunnel/actions/runs/42083768435).
   
   `DruidIT.testDruidSink` also fails with a Spark-only scope, for a different 
reason. #11307 already changes its conf, so this PR leaves it alone.
   
   Also run: `spotless:check`, and `verify -DskipTests` on the transform E2E 
modules.
   
   ### Check list
   
   * [x] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
 (no new jar)
   * [x] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs (not needed)
   * [x] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR. (not needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

  • [PR] [Fix][E2E] Skip transform... SEPURI-SAI-KRISHNA (via GitHub) via commits

Reply via email to