DanielLeens commented on issue #13116: URL: https://github.com/apache/seatunnel/issues/13116#issuecomment-6630286288
Thanks for isolating both stale configuration paths. I checked current `dev` and can confirm the observations: - `SlsSinkWriter` reads `log_group_size`, but `write()` immediately sends each serialized row with `PutLogs`; the SLS `OptionRule` does not expose that option. - `target_columns` and `json_column_name` are not consumed by the SensorsData write path; adding an option to an `OptionRule` alone would not give it a defined runtime meaning. Could you please add an English version of the report? English keeps the issue searchable and lets the wider community review the compatibility decision. In that update, please choose and justify one independently reviewable path for each connector: 1. **SLS batching:** specify the buffering limit (including SDK request-size limits), flush points (`prepareCommit`/checkpoint and `close`), failure and retry behavior, ordering, and the expected checkpoint semantics. A PR needs a focused test plus an SLS integration result; changing `write()` to buffer is an observable delivery-semantics change. 2. **Removal:** do not remove or rename the public keys until the compatibility impact is established for released configurations. Please trace when each key became accepted, whether any release documentation or examples exposed it, and provide migration guidance if removal is still the proposed path. For SensorsData, please first establish the intended historical behavior. If neither key has a supported consumer, a small removal-only PR with the compatibility evidence and matching documentation cleanup is preferable to registering undocumented options with no behavior. Please keep the SLS and SensorsData changes in separate PRs so their runtime and compatibility risks can be reviewed independently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
