SEZ9 commented on issue #10753: URL: https://github.com/apache/seatunnel/issues/10753#issuecomment-6567812394
@SEPURI-SAI-KRISHNA thanks for the thorough write-up on the **JMS / AMQP (generic)** row. Recording it as claimed by you, in design review under #13078, is fine from my side; that should be enough to avoid duplicated work while the open questions are settled. A few comments on the direction, with the detailed discussion staying on #13078: - A single `connector-jms` on the standard JMS 1.1 API with user-supplied vendor client jars, mirroring how JDBC drivers are handled, is a reasonable shape for the generic row. Keeping `connector-activemq` and `connector-rabbitmq` untouched is the right call; please state that explicitly in the note so nobody reads this as a replacement for #12341. - The point about session-wide acknowledgement is well taken, and one transacted session per checkpoint epoch, committed only after the checkpoint completes, is the kind of mechanism this row has been missing. Please make sure the note spells out how the final checkpoint on job stop is handled and what happens to in-flight messages if the commit itself fails after the checkpoint is confirmed. - The three-broker check on JDK 11 and 17 plus the negative control is very useful. Please include enough detail in #13078 (broker versions, the failure that was injected, what was observed) so reviewers can reproduce it. - On licence: confirming that the Geronimo JMS 1.1 spec jar is the only new dependency and that no vendor client is bundled is what we need; please keep that statement in the note. Concrete asks before coding starts: 1. Resolve the four open questions (scope, naming, vendor jar location, slice order) on #13078 and summarize the outcome there. 2. When the source slice PR is opened, post a short status here so the row can move from design review to in progress, and keep source and sink as separate PRs as you proposed. I will update the tracker row accordingly. <!-- streview-comment:2210 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
