DanielLeens commented on PR #11077: URL: https://github.com/apache/seatunnel/pull/11077#issuecomment-6699537188
Thanks for picking this back up, @hesam-oxe, and no need to apologize. Here's a short summary so the next commit only covers what is actually still open. **Already done in code, please keep as is.** Most of the older F1-F8 list is already handled on this head. `MultiTableSink.java:142-174` validates physical row layouts, `:225-228` creates the writer outside `computeIfAbsent` and keeps `IOException`, and `:248-251` registers a context for every alias. `MultiTableSinkWriter` also groups shared instances by identity for snapshot and close. Please don't rewrite these. The per-destination writer lifecycle and close ordering can stay as they are. **Still blocking, from my head review:** 1. Issue 2: the EN and ZH `incompatible-changes.md` entries and the PR release note promise a startup `IllegalStateException` that can't happen for the file sink. Please change them to describe the actual behavior. 2. Issue 3: add tests that pin the new destination-identifier components (next to `HdfsFileSinkTest`), plus a sharing test with metadata-only schema differences (in `MultiTableSinkWriterTest`). 3. The branch now conflicts with `dev` (GitHub reports `CONFLICTING`). Please resolve against `dev` (the base branch is `dev`, not `develop`) and keep both sides' changes. **CI notes:** #12115 (RocketMQ broker identity and route wait) was merged into `dev` on 2026-09-18, so syncing will pick it up. Nothing else needs to land first. The apache `Build` check on this head is still `action_required` with no fork run, so after you push, please trigger the existing fork `Build` workflow on the new head. If doris or transform-v2 still fail after that, paste the job links and I'll check whether they also fail on `dev`. Optional, not blocking: Issue 4 (digest instead of a 32-bit `hashCode` for the Hadoop options) and the low-severity items in Issue 5. Once the new head is up, ping me and I'll do a full re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
