DanielLeens commented on issue #13052: URL: https://github.com/apache/seatunnel/issues/13052#issuecomment-6702873373
Thanks for resolving the ownership ambiguity. I verified that #12165 is still open against `dev`, remains `REVIEW_REQUIRED`/`BLOCKED`, and has no completed checks. The published follow-up commit `f1c125f` is stacked on the earlier #12165 head `a932e27a7`, so it cannot be reviewed or merged independently yet. @KaustAbhinand, please coordinate with @Vivek1106-04 and do not open a competing implementation for this issue. Once #12165 is merged, please rebase the follow-up onto the current `dev`, open it as a focused PR linked to #13052, and keep the review on that PR. The PR should show that each deferred error path carries the coordinator generation that started the work and cannot update `errorByPhysicalVertex` or fail a replacement generation after `restoreCoordinator()`. Please keep `notifyCompleted`, `reportCheckpointErrorFromTask`, and the task-running-failed path unchanged unless the PR demonstrates an unambiguous stale-generation path for each. The regression coverage should deterministically release an old async failure after restore (the restored generation stays running and retains its own error state) and show that the same failure still fails its owner when no restore occurs. Thank you for preserving the narrow stacked dependency; the next maintainer review can evaluate the rebased head and its CI evidence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
