SEPURI-SAI-KRISHNA commented on PR #13092: URL: https://github.com/apache/seatunnel/pull/13092#issuecomment-6710518494
I merged `dev` again and added one commit for a conflict with #12828 (CockroachDB dialect). `CockroachDBDialect.hashModForField` wrapped the hash in `COALESCE(..., 0)`, so rows with a NULL key were read by hash bucket 0. This PR also adds a split for those rows, so on CockroachDB they were read twice. `JdbcCockroachDBDialectIT` caught it: it expected 3 splits and got 4. The commit drops the `COALESCE`, so a NULL key matches no hash bucket on CockroachDB, as on the other dialects, and is read only by the NULL split. It also updates the expected hash in `CockroachDBDialectTest`, expects 4 splits in `JdbcCockroachDBDialectIT` (which still checks that every row is read once), and updates the CockroachDB note in the source docs, EN and ZH. Locally on JDK 17: `spotless:check`, the `connector-jdbc` unit tests (1232 run, no failures; the only 4 errors are Testcontainers classes, since I have no Docker), and the E2E module compiles. I could not run `JdbcCockroachDBDialectIT` locally, so the fork run is its check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
