SEPURI-SAI-KRISHNA commented on PR #12976: URL: https://github.com/apache/seatunnel/pull/12976#issuecomment-6710934655
I merged `dev` again. It conflicted with #12703 (`UNIX_TIMESTAMP`), which added `getFormatter` in `DateTimeFunction`. `getFormatter` already uses `Locale.ENGLISH`, and `FROM_UNIXTIME` and `UNIX_TIMESTAMP` use it on `dev`, so half of this PR is already in `dev`. What the merge does: - `FROM_UNIXTIME` keeps `dev`'s `getFormatter(format)`. - `FORMATDATETIME`, which still used the worker's default locale on `dev`, now calls `getFormatter(format)` too instead of its own `ofPattern(format, Locale.ENGLISH)`. The result is the same formatter, and both functions now share one place. - `sql-functions.md` (EN and ZH): `dev` added "Text pattern letters ... are interpreted in English" under `FROM_UNIXTIME`, so I removed this PR's sentence that said the same and kept only the note on the week fields. - `incompatible-changes.md` (EN and ZH): this PR's entry now covers `FORMATDATETIME` and points to #12703's entry for `FROM_UNIXTIME`. It still says the week fields `Y`, `w`, `W`, `e` and `c` follow the English rules for both functions, which #12703's entry does not mention. Run on JDK 17: `spotless:check`, and the `seatunnel-transforms-v2` unit tests (1960, including `SQLDateTimeFunctionsTest` from both PRs). With `FORMATDATETIME` put back on the default locale, `testFormatDateTimeTextIsEnglishUnderAnyDefaultLocale` and `testFormatDateTimeWeekFieldsUseEnglishWeekRulesUnderAnyDefaultLocale` fail, so the tests still cover the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
