chovy-3012 opened a new pull request, #13172:
URL: https://github.com/apache/seatunnel/pull/13172
### Purpose of this pull request
Fixes #13171 and corrects an error code typo, both found while auditing the
Doris source connector.
- **Duplicate `table_list` entries were silently accepted.** The uniqueness
check in `DorisTableConfig#of` used `tableIdSet.size() < tableList.size() - 1`,
so exactly one redundant entry (e.g. `[db.t1, db.t1]`) passed silently;
`DorisSourceFactory` then overwrote it in its `TablePath`-keyed map, dropping
the first entry's own `doris.read.field` / `doris.filter.query` without
warning. Dropping the `- 1` makes duplicates fail fast at job submission.
- **Error code typo.** `DorisConnectorErrorCode.SCHEMA_FAILED` carried
`"Doirs-08"`; corrected to `"Doris-08"` (the constant is never thrown today, so
this is a contract-level fix).
### Does this PR introduce _any_ user-facing change?
Yes. A duplicate `database`.`table` in `table_list` now fails at job
submission with "Please configure unique `database`.`table`, not allow
null/duplicate: ..." instead of being silently accepted (last entry wins).
Compared to released versions (3.1.0, 2.3.x) this tightens validation of an
undocumented misconfiguration; no config options or defaults changed. The
constraint is documented in the Note paragraph of the EN/ZH `Doris.md`.
### How was this patch tested?
No unit tests added — the fix is a one-line condition correction. Verified
with a before/after end-to-end run on the packaged runtime (no Doris backend
needed — the check fires at config parsing): on the base revision, a duplicate
`table_list` `[test_db.table1, test_db.table1]` passed parsing silently and the
job failed later at catalog connect with a misleading `CatalogException`; with
this fix the job fails immediately at submission with the message above.
`javap` on the deployed connector jar confirms the `Doris-08` constant
(previously `Doirs-08`). spotless clean.
### Check list
* [x] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
— no new jar/dependency added
* [x] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs — EN/ZH `Doris.md`
Note paragraph updated with the uniqueness constraint
* [x] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR. — not needed: only undocumented duplicate
entries are rejected; no valid config changes behavior
* [ ] If you are contributing the connector code, please check that the
following files are updated — existing connector modified, no new connector
added (plugin-mapping.properties / seatunnel-dist pom / label-scope-conf /
plugin_config unchanged); no new e2e testcase added — verification done via a
before/after end-to-end run, see "How was this patch tested"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]