SEZ9 commented on issue #13080: URL: https://github.com/apache/seatunnel/issues/13080#issuecomment-6623122556
Thanks @sharpca. Two points remain before the detailed review can continue on the PR: 1. **CI** — as noted above, the PR's `Build` check reports the workflow run from your fork, and the fork currently has no workflow runs, so there is nothing for a maintainer to approve. Please enable Actions in your fork and run the `Build` workflow against the PR branch so a run for head `3dc5920e` is picked up, then post here once it has executed. 2. **`--checkpoint-history-status`** — this is still parsed with a default-locale `toUpperCase()` in `ClientExecuteCommand`. Please let us know whether you want to fix it in the PR with `Locale.ROOT` plus a Turkish-locale assertion, or have it tracked separately. The coverage summary you posted reads well; it will be checked against the diff during review on the PR. <!-- streview-comment:2274 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
