goutamadwant commented on PR #12251: URL: https://github.com/apache/seatunnel/pull/12251#issuecomment-6651163199
Thanks @SEZ9. These refer to head `ab016a9042`; no new push. - F3: Not implemented; it behaves like `FAIL`. `handleConversionError` throws for any non-`SKIP` policy (`JsonPathTransform.java:236-248`) and the row handler rethrows it (`AbstractSeaTunnelTransform.java:94-107`). Documented at `jsonpath.md:26-30`, `:85`, `:261-262`; tested at `JsonPathErrorHandlingTest.java:545-557`. Routing needs a second output table, like DataValidator, so I'd leave it for a follow-up. - F4: Yes: `jsonpath.md:20-31`, `:83-86`, `:252-284`, example `:286-301` (zh `:20-30`, `:82-84`, `:250-273`, `:275`). - F5: Yes: `incompatible-changes.md:281-287` (zh `:229-233`). - F6: Still separate. The policy cases use the public config API. Only 5 of 24 tests reflect into `converters` (`:660-669`), to inject cyclic chains, wrapped `Error`s and suppressed payloads that real JSON can't produce. A rename fails with `NoSuchFieldException`. I can move the public-API cases into `testErrorHandleWay` if you prefer. - F8: Yes, path-read errors only (`JsonPathTransform.java:288`); conversion failures have no cause. `ErrorDataTransformException` has no cause constructor (`ErrorDataTransformException.java:31-54`), and the row handler needs its `errorHandleWay`. CI: all-connectors-it-3 (17) timed out; a re-run of the failed job started today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
