goutamadwant opened a new pull request, #13180:
URL: https://github.com/apache/seatunnel/pull/13180
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code
changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB
issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix
typo in README.md doc`.
-->
### Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull
request adds checkstyle plugin.-->
I’m contributing this fix to SeaTunnel so multi-table wrappers initialize
and release the per-table transforms they own.
Fixes #13131.
- Forward lifecycle callbacks once per owned child, including composed Map
and FlatMap rules.
- Stop initialization on failure and clean up partially built or initialized
children. Continue sibling cleanup while retaining the original failure.
- Reuse schema-initialized SQL engines and model clients, prevent late
initialization after close, and preserve Python startup cancellation.
- Keep lifecycle state transient and retain existing routing and
serialization behavior. Update the English and Chinese contributor guides.
Engine-side failure propagation remains in #13132 / #13175. This patch
contains no engine production changes.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new
specifications: https://github.com/apache/seatunnel/issues/4544.
-->
Yes. On `dev`, affected multi-table wrappers currently skip child
initialization and cleanup. They now forward both callbacks, release
schema-time resources and retain startup/cleanup failures without duplicate
callbacks.
No configuration options, dependencies or public method signatures change.
All seven affected serialization UIDs remain unchanged.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If you are adding E2E test cases, maybe refer to
https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf,
here is a good example.
-->
Validated locally with JDK 11:
- 1,998 transform tests and 498 API/common tests passed.
- Extended existing tests for successful startup, partial failures,
constructor cleanup, repeated/concurrent callbacks, identity children, composed
rules and serialization.
- Real loopback Embedding and Python subprocess checks verified client
reuse, connection-pool shutdown, startup cancellation and process/thread/script
cleanup.
- Eight native Zeta jobs passed with unchanged engine code, covering
Map/FlatMap, empty/nonempty input and ALL/OFF thread sharing. Checked
callbacks, output counts and released resources.
- Spotless checks passed. The full Docker/Failsafe suite was not run.
Unit-test commands:
```sh
export MAVEN_OPTS="-Xmx3g -XX:ActiveProcessorCount=4"
./mvnw -Pci -pl seatunnel-transforms-v2 -am \
"-Dsurefire.jvm.args=-Xmx3g -XX:ActiveProcessorCount=4
-javaagent:$HOME/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.19/byte-buddy-agent-1.12.19.jar"
verify
./mvnw -Pci -pl seatunnel-transforms-v2 \
"-Dsurefire.jvm.args=-Xmx3g -XX:ActiveProcessorCount=4
-javaagent:$HOME/.m2/repository/net/bytebuddy/byte-buddy-agent/1.12.19/byte-buddy-agent-1.12.19.jar"
verify
```
Native integration exercised
`LocalModeIT.multiTableLifecycleForEmptyAndNonemptyJobs` through JUnit
Platform, with assertions for resource and output counts.
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [x] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]