LuckysHorizon commented on PR #13136: URL: https://github.com/apache/seatunnel/pull/13136#issuecomment-6717945559
> Thanks @LuckysHorizon for the update, and for running the compile and `CoordinatorServiceTest` locally. That's helpful context. This is a short re-review of head `718f00b8`. > > ### What changed since my last review (`6f745fc2`) > Only the empty "Trigger CI" commit. Its tree is identical to `6f745fc2`, so no code, test or doc changed. My previous conclusion still holds: there are no non-CI blockers. The `getJobInfo()` precedence in `CoordinatorService.java:1910-1936` (running, then pending, then distributed `JobInfo`, then history) and the regression test in `CoordinatorServiceTest.java:1511-1590` are unchanged and still look correct to me. > > ### CI status on this head > * I checked your fork run for this head, https://github.com/LuckysHorizon/seatunnel/actions/runs/42203281071. Every job shows as failed or skipped without running a single step. GitHub's annotation on those jobs says: "The job was not started because your account is locked due to a billing issue." That matches what you described. So Actions is enabled on the fork, but it can't run right now. No Build check has ever run for this branch on `apache/seatunnel`. > * On the apache side, the `PR signal` run for this head (https://github.com/apache/seatunnel/actions/runs/42203285385) is in `action_required` and waiting for a maintainer to approve it. Please note that approving it won't produce the Build result by itself. In this repo, the Build check is reported from the contributor fork's run, so the billing lock on the fork still has to be cleared first. > > Your local results are appreciated, but they can't replace the CI matrix, which covers Java 11/17, Windows and the engine/e2e jobs. **CI_NOT_ENABLED**: could you please resolve the billing lock on your GitHub account (Settings -> Billing and plans), then re-run the workflow at https://github.com/LuckysHorizon/seatunnel/actions/runs/42203281071 (or push another empty commit) so the Build check attaches to this PR? > > ### Merge state > There are no conflicts. The branch is 10 commits behind `dev`, which doesn't need a sync by itself. #13133 is still open and overlaps with this change, so maintainers should land only one of the two. > > ### Merge Recommendation > **Ready to merge after fixes** > > * Blockers: CI only. A Build needs to run and pass on this head, and a maintainer needs to approve the `PR signal` run. No non-CI blockers remain. > > I'm leaving this as COMMENT because CI hasn't run yet. I'll be happy to approve once the Build is green on this head. Nice work. Thanks, @DanielLeens, and thanks for checking the fork run and explaining how the Build check gets attached. That is useful to know. I can't clear the billing lock right now. I expect it to take roughly 18 more hours to get fixed. Once it clears, I'll re-run the workflow at https://github.com/LuckysHorizon/seatunnel/actions/runs/42203281071, so the Build check attaches to this PR, and I'll post the result here. If the re-run doesn't attach, I'll push another empty commit. Nothing else is needed from you in the meantime. The code, tests and docs are unchanged since 6f745fc2. Thanks for your patience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
