Yuaneen opened a new pull request, #13187:
URL: https://github.com/apache/seatunnel/pull/13187

   ### Purpose of this pull request
   
   `seatunnel-api` matches plugin identifiers and type names with 
default-locale `toUpperCase()` / `toLowerCase()`. On a worker JVM whose default 
locale is `tr-TR` (or `az`), `I`/`i` fold to `ı`/`İ`, so:
   
   - `PluginIdentifier.hashCode()` disagrees with its locale-independent 
`equals()` (`StringUtils.equalsIgnoreCase`), so two equal identifiers can land 
in different `HashMap` buckets and plugin discovery lookups miss.
   - `MetalakeConfigUtils` turns a configured `gravitino` into `GRAVİTİNO` and 
`MetaLakeType.valueOf()` throws `No enum constant`.
   - `MetaLakeFactory` client/mapper registry keys and lookups no longer match.
   - `GravitinoTableSchemaConvertor` fails to match types such as `INTEGER`.
   
   This PR uses `Locale.ROOT` for those identifier and type-name conversions. 
Equality and matching semantics are unchanged for every other locale.
   
   Closes #13169
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, in the narrow sense that broken behavior under Turkish/Azerbaijani 
locales is fixed: plugin lookups no longer miss and metalake/Gravitino type 
resolution no longer fails when the JVM default locale folds `i`/`I`. No new 
option, configuration key, or API shape is introduced.
   
   ### How was this patch tested?
   
   New and extended unit tests run under a `tr-TR` default locale:
   
   - `PluginIdentifierTest` — case-different identifiers are equal, hash 
equally, and resolve from a `HashMap`.
   - `MetaLakeFactoryTest` — `createClient` / `createTypeMapper` resolve 
`GRAVITINO`.
   - 
`GravitinoTableSchemaConvertorTest#testTypeMatchingIsIndependentOfDefaultLocale`
 — `"INTEGER"` converts to `INT_TYPE`.
   
   Verification:
   
   ```
   ./mvnw -pl seatunnel-api -am package
   Tests run: 57, Failures: 0, Errors: 0, Skipped: 0
   BUILD SUCCESS
   
   ./mvnw -pl seatunnel-api spotless:check
   BUILD SUCCESS
   ```
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new 
feature.
   * [ ] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR.
   * [ ] If you are contributing the connector code, please check that the 
following files are updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to