DanielLeens commented on PR #13093: URL: https://github.com/apache/seatunnel/pull/13093#issuecomment-6646610487
The merge-state fact in my latest review has changed: GitHub now reports actual conflicts with dev (DIRTY), so the earlier no-conflicts/no-sync statement no longer applies. Please sync latest dev and resolve the conflicts while preserving this connector and the shared registration changes, then rerun the required checks on the resolved head. The current failed engine-resource-managers-it JDK 17 lane still reports KubernetesApplicationRecoveryIT.livePodLogs returning null; the corresponding fixture is unchanged in latest dev, so conflict resolution is not a demonstrated code fix for that failure. Keep its targeted retry/log investigation separate. My source conclusion remains clear and optional findings remain optional. This is an unchanged-head CI/merge clarification, not another full source review. No local runtime testing was performed. Daniel has READ permission; effective maintainer approval/dismissal remains separate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
