lxcxjxhx commented on PR #13113: URL: https://github.com/apache/seatunnel/pull/13113#issuecomment-6665342143
Done in `1c411099` (branch also merges current `dev`, so the option source is up to date): - `docs/en/connectors/sink/Mem0.md` and `docs/zh/connectors/sink/Mem0.md` now list `retry`, `retry_backoff_multiplier_ms` and `retry_backoff_max_ms`. - Values come from the declarations, not from memory: `Mem0SinkOptions extends HttpCommonOptions`, so the three options are `retry` (no default), `retry_backoff_multiplier_ms` (default `100`, `DEFAULT_RETRY_BACKOFF_MULTIPLIER_MS`) and `retry_backoff_max_ms` (default `10000`, `DEFAULT_RETRY_BACKOFF_MAX_MS`). All three are optional in `optionRule()`. - One sentence under each table says the three options are inherited from the shared HTTP sink options, so the table does not read as if Mem0 defined them itself. Table padding left unchanged, as you said it stays optional. Acknowledged on the CI point: the earlier request about enabling/running fork CI is obsolete; the remaining item was the reference-documentation correction, which this commit covers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
