ryanmeowy commented on PR #13143:
URL: https://github.com/apache/seatunnel/pull/13143#issuecomment-6681723704

   Thanks @DanielLeens for the thorough review and the approval.
   
   CI is green on the current head (`f666fb8fe`): the `Build` run finished with 
31 jobs successful and 39 skipped, including `connector-file-local-it (11)` and 
`(17)`, so the new e2e case now runs in CI. The earlier red was an unrelated 
flaky `RestApiHttpsForTruststoreTest` plus the 120-minute job timeout on a cold 
Maven cache; both cleared on the rerun.
   
   On the two non-blocking notes:
   
   - **E2E output directory**: agreed — the test should remove 
`/tmp/seatunnel/text_null_partition` before the job so the `ls -d` assertion 
always reflects the current run. I will pick this up together with the docs 
below, to avoid resetting a green CI run here.
   - **NULL rendering docs for the other file sinks**: the rule lives in 
`AbstractWriteStrategy`, so the same sentence belongs in the other file sink 
pages (13 connectors × en/zh). I will send that as a separate docs PR right 
after this one lands, unless maintainers prefer it folded into this PR.
   
   Could a committer take a look when convenient?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to