hawk9821 commented on code in PR #25:
URL: https://github.com/apache/seatunnel-shade/pull/25#discussion_r4511065493


##########
seatunnel-shade-hazelcast/pom.xml:
##########
@@ -48,7 +52,62 @@
     </dependencies>
 
     <build>
+        <resources>
+            <resource>
+                <directory>src/main/resources</directory>
+            </resource>
+            <resource>
+                <directory>${hazelcast.notices.directory}</directory>
+            </resource>
+        </resources>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-antrun-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>prepare-hazelcast-notices</id>
+                        <phase>generate-resources</phase>
+                        <goals>
+                            <goal>run</goal>
+                        </goals>
+                        <configuration>
+                            <target>
+                                <!-- Hazelcast 5.1.7 bundles public-domain 
JSON-java but carries its old license text. -->
+                                <unzip src="${com.hazelcast:hazelcast:jar}" 
dest="${hazelcast.notices.directory}">
+                                    <patternset>
+                                        <include 
name="META-INF/THIRD-PARTY.txt" />

Review Comment:
   Thanks for the update. I've checked the original `hazelcast-5.1.7.jar` and 
confirmed that its `META-INF/THIRD-PARTY.txt` now lists `JSON in Java:20230227` 
under **Public Domain**. This completely resolves the ASF Category X compliance 
issue at the source.
   
   However, to make this PR perfectly clean, we need to address the following:
   
   1. **Remove the `maven-antrun-plugin`**: Since Hazelcast 5.1.7 is now fully 
compliant, the script that uses regex to modify Hazelcast's `THIRD-PARTY.txt` 
is no longer needed. Leaving it in the codebase is highly risky, as ASF 
reviewers might misunderstand it as an attempt to tamper with license 
declarations. Please delete this plugin.
   2. **Verify the final Fat Jar**: Please run `mvn clean package` and verify 
that the final `seatunnel-shade-hazelcast-*.jar` actually contains 
`META-INF/maven/org.json/json/pom.properties` with version `20230227`, ensuring 
no other modules are downgrading it back to `20201115`.
   
   Once the `antrun` plugin is removed and the final artifact is verified, this 
PR looks good to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to