SEPURI-SAI-KRISHNA commented on issue #13189:
URL: https://github.com/apache/seatunnel/issues/13189#issuecomment-6740791387

   Thanks for reading it closely. I have no NetSuite account, so I cannot add 
sandbox evidence myself.
   
   The two closest connectors were merged on mocks alone: the Intercom (#12831) 
and Typeform (#12844) PRs say they were not tested against a live account. This 
design does the same, and for the points the docs do not settle it fails the 
job instead of guessing:
   
   - checkbox values: only `T`/`F` or `true`/`false` are accepted, anything 
else fails
   - dates and timestamps: only the two `TO_CHAR` formats are accepted, 
anything else fails, and the docs will say the timestamp has no zone
   - a NULL column, whether omitted or sent as `null`, is read as NULL
   - the 100,000 cap: table mode never reaches it, and query mode fails before 
reading when `totalResults` is above it
   - the token: there is no refresh token, so the reader asks for a new one 
before expiry and once on a `401`
   
   On the other points:
   
   - `table`, `key_column` and the column names from `schema` must be plain 
identifiers (letters, digits and `_`, starting with a letter), checked before 
any query is built. Anything else fails the job.
   - `filter` and `query` are SuiteQL written by the user, like the JDBC 
source's `query`. The docs will say so.
   - One bounded split, no secret in logs, errors or state, TLS and hostname 
checks never turned off. `base_url` stays because sandbox hosts need it, and it 
is documented for sandboxes and tests.
   
   @davidzollo, as the owner of #10753, is that enough to start, with the PR 
saying clearly what the mocks prove and what still needs a real account? If 
live evidence is required first, I will leave the connector until someone with 
a sandbox can help. I can write the exact queries for them to run.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to