DanielLeens commented on PR #13177: URL: https://github.com/apache/seatunnel/pull/13177#issuecomment-6755992118
Hi @goutamadwant, a short follow-up to my last review of `56a75427`. The fork `Build` run has now finished (https://github.com/goutamadwant/seatunnel/actions/runs/42581380747), and the failures are the same ones I described: `connector-file-sftp-it` (11/17, removed `atmoz/sftp:alpine-3.7` image), `engine-k8s-it (17)` (k3s download error) and `jdbc-connectors-it-part-6 (11)` (Docker Hub 502). None are caused by this PR. One new thing: GitHub now reports a merge conflict with `dev`. #13061 (merged today) added entries to `docs/en|zh/introduction/concepts/incompatible-changes.md`, which this PR also edits. Keeping both entries should be enough. The SFTP image fix is #13203, which is still open, so a `dev` sync will not clear that job yet. Suggested next step: once #13203 is merged, merge the latest `dev` once. That resolves the conflict and picks up the SFTP fix in the same CI run. My conclusion is unchanged: no blockers from source review, and I will approve once `Build` is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
