zhangshenghang opened a new pull request, #13213:
URL: https://github.com/apache/seatunnel/pull/13213

   Yes, I'm glad to contribute to Apache SeaTunnel.
   
   ### Purpose of this pull request
   
   Follow-up to #13203 (#13202).
   
   #13203 fixed `SftpFileIT` by moving it from the removed 
`atmoz/sftp:alpine-3.7` tag to `atmoz/sftp:alpine`. That works today, but 
upstream now publishes only three floating tags (`latest`, `debian`, `alpine`) 
and has already removed its versioned tags once, so the same `manifest unknown` 
failure can come back whenever upstream rebuilds or prunes a tag.
   
   As suggested in the review of #13203 ("We should put it in the image 
repository under seatunnel later"), this PR points the test at a copy of that 
image kept in the project's own Docker Hub namespace, consistent with the other 
`seatunnelhub/*` images the E2E tests already use 
(`seatunnelhub/starrocks-starter:2.2.1`, `seatunnelhub/hbase-standalone:2.4.9`, 
`seatunnelhub/oracle-19.3.0-ee:non-cdb`, ...):
   
   ```diff
   -    private static final String SFTP_IMAGE = "atmoz/sftp:alpine";
   +    private static final String SFTP_IMAGE = "seatunnelhub/sftp:alpine";
   ```
   
   The mirror is a byte-for-byte registry copy, not a rebuild: at the time of 
writing, both `atmoz/sftp:alpine` and `seatunnelhub/sftp:alpine` resolve to the 
same manifest digest 
`sha256:c5fb9e4beb8b7054a4c0b65c5e11df47cc20da95ad6002e88aecff62bab06372` 
(linux/amd64, Alpine 3.24.4 base, image created 2026-11-06 from 
atmoz/sftp@46a8b3d). Nothing else changes: the container is started the same 
way, with the same command (`seatunnel:pass:::tmp`), port and paths.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No. Test only.
   
   ### How was this patch tested?
   
   - Mirror integrity, verified anonymously the way CI pulls images:
     ```shell
     docker buildx imagetools inspect seatunnelhub/sftp:alpine
     ```
     returns `Digest: sha256:c5fb9e4b...`, identical to `atmoz/sftp:alpine`; 
the manifest, image config and all 5 layers were downloaded anonymously from 
`seatunnelhub/sftp` and every SHA-256 and size matches.
   - `./mvnw spotless:apply` and `./mvnw -q -DskipTests verify` pass locally on 
JDK 17.
   - `SftpFileIT` is exercised by this PR's `connector-file-sftp-it` CI job. 
The image content is identical to the one #13203 validated — that PR's CI run 
(https://github.com/SEPURI-SAI-KRISHNA/seatunnel/actions/runs/42617830822) ran 
`connector-file-sftp-it` on JDK 11 and 17 against the same digest and both jobs 
passed. The IT was not run locally.
   
   ### Check list
   
   * [X] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
 (no new jar)
   * [X] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs (not needed, test 
only)
   * [X] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR (not needed, test only)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to