DanielLeens commented on issue #13207:
URL: https://github.com/apache/seatunnel/issues/13207#issuecomment-6766874376

   Thank you for the concrete configuration and stack trace. Please rotate the 
credentials that were included in the public Issue and replace them with 
redacted values.
   
   The current `dev` call path confirms the failure before a connection is 
made: `SqlServerIncrementalSourceFactory` passes the configured table text to 
`TablePath.of(text, true)`, and `TablePath.of(String)` accepts at most three 
dot-separated components. A value such as `LIS6.0.dbo.LIS_ITEM` has four 
components, so it fails during source construction exactly as reported.
   
   The fix should remain local to SQL Server CDC. `TablePath` uses dots as 
structural separators for many connectors and cannot infer that `LIS6.0` is one 
database identifier. The SQL Server factory has the required configuration 
context, so it should normalize a dotted database name without changing the 
global `TablePath` grammar.
   
   A focused PR should preserve the existing ordinary `database.schema.table` 
behavior, construct the expected `(database, schema, table)` path for a 
database name containing a dot, and reject genuinely ambiguous input clearly. 
Please add the regression to the existing 
`SqlServerIncrementalSourceFactoryTest`, then validate the same selection 
through SQL Server CDC snapshot and incremental discovery. Please also include 
the exact 3.0.x distribution version and the test results in the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to