DanielLeens commented on PR #12829:
URL: https://github.com/apache/seatunnel/pull/12829#issuecomment-6783185776

   Thanks @nzw921rx for taking another look. I re-checked both items on the 
current head `8b038dfac`, and I still think they are already covered, because 
this PR adds a source to the existing `connector-couchbase` artifact instead of 
shipping a new plugin jar:
   
   - `config/plugin_config:104` already lists `connector-couchbase`.
   - `seatunnel-dist/pom.xml:637` already declares the `connector-couchbase` 
dependency, so the jar that now contains both `CouchbaseSource` and 
`CouchbaseSink` is already in the distribution.
   - `plugin-mapping.properties:86` is the one registration that does need a 
change, and this PR adds `seatunnel.source.Couchbase = connector-couchbase` 
there, next to the existing sink entry at line 87.
   
   Adding a second `connector-couchbase` entry to either file would duplicate 
the existing one. If you have something else in mind (for example a separate 
artifact, or a different packaging list), could you point to the file or the 
place you expect the change? Then @goutamadwant and I can check that exact spot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to