MyeoungDev commented on PR #11222:
URL: https://github.com/apache/seatunnel/pull/11222#issuecomment-6785204904

   Thanks @SEZ9 @DanielLeens. pushed an update.
   
   Vectors are now copied as a full heap buffer (whole capacity, position 0). I 
didn't keep the source position as suggested, since `VectorUtils.toFloatArray` 
reads by capacity and would underflow. Added unit tests for moved position, 
direct buffer and byte order, and the vector E2E now checks the copy with 
`VECTOR_DIMS` and `L2_DISTANCE`.
   
   Removed multiple_row. It can't be declared as a column type, and multi-table 
Copy already works without it. Happy to bring it back if you'd prefer.
   
   Also added supported types and the Spark note to the docs, the instanceof 
guards, the Assert comment, and the indentation fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to