DanielLeens commented on issue #13226: URL: https://github.com/apache/seatunnel/issues/13226#issuecomment-6795343583
Thanks for documenting the propagation points and the compatibility constraints so clearly. The current `dev` code confirms the central gap: `EnvOptionRule` already accepts `EnvCommonOptions.CUSTOM_PARAMETERS`, and `MultipleTableJobConfigParser` copies the parsed `env` map into `JobConfig`, but `TableFactoryContext` currently retains only the plugin options and class loader. The Zeta factory calls therefore have no separate `env` view today. This is an additive API proposal, but it crosses the public factory contract, Zeta parser/dry-run paths, and serialized SQL transform state. Please keep the delivery reviewable in two stages: 1. First add the immutable, separate environment view to the factory contexts and propagate it only through the Zeta source, transform, sink, multi-sink and dry-run paths. Existing constructors and `FactoryUtil` entry points must retain their current behavior by delegating with an empty environment; do not merge `env` into connector options or change Flink/Spark behavior. 2. Then add the SQL and Calcite UDF integration. The tests must cover both ordinary local submission and REST submission, job isolation when UDF classes share a JVM, and restore/serialization behavior. `CalciteUdfContext` must not leave job-specific state in a static or thread-local context after evaluation. Please keep `custom_parameters` out of the credential path: the existing configuration shading flow does not make `env` a secret store. Before opening the first PR, add the concrete constructor/overload compatibility table and the planned serialization compatibility treatment to this Issue. The initial PR should include focused API and Zeta-path tests plus EN/ZH documentation; UDF framework changes can follow once that API contract is settled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
