SEPURI-SAI-KRISHNA commented on PR #13235:
URL: https://github.com/apache/seatunnel/pull/13235#issuecomment-6814532865
Thanks for picking this up. I read the diff against #13232 and the validator
code on dev. Two points and a nit:
1. CI has not run. The PR shows no `Build` check, for two reasons: the
`Build` workflow runs in the contributor's fork (`build_main.yml`, on push),
and `amalsaidov/seatunnel` has no workflow runs yet, so Actions probably needs
to be enabled in the fork's Actions tab, then a new push or a manual run of
`Build` on this branch. Separately, the `PR signal` run of this PR is waiting
for approval (`action_required`), which a committer has to give.
2. The error no longer shows the rejected value, as also noted on #13232,
which lists it in its acceptance criteria ("Keep diagnostics identifying the
option and invalid value"). With only the rule added, the cause message is
built from `OptionUtil` `ERROR_TEMPLATE` and `Condition.conditionToString`,
which print the key, the operator and the bound, not the configured value. I
applied the same rule and constructor change to dev and ran it with `-1`; the
cause reads:
```
Option validation failed (1 error):
[1] option: multi_table_sink_replica
type: value
constraint: 'multi_table_sink_replica' > 0
```
and the outer `FactoryException` is the generic "Unable to create a sink for
identifier 'MultiTableSink'." (`FactoryUtil.java:283`). So a user who set `0`
or `-1` does not see that value anywhere. The old test asserted the value, and
the reworked tests dropped that assertion, so nothing catches it now.
3. Nit: the issue asks to remove the constructor comment. The PR rewrites it
in the constructor and adds a similar one in
`MultiTableSinkFactory.optionRule()`.
The rule itself and the removal of the constructor check look right to me,
and every production path (Zeta parser, Flink, Spark, and the starter config
check) goes through `FactoryUtil.createMultiTableSink`, so moving the check
there loses no coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]