This is an automated email from the ASF dual-hosted git repository.
nzw921rx pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new c5fed72086 [Fix][Zeta] Remove obsolete checkpoint overview storage
benchmark (#13255)
c5fed72086 is described below
commit c5fed7208676369a811cbdca12dc8104b587cfb7
Author: zhiweiniu <[email protected]>
AuthorDate: Thu Nov 12 23:00:54 2026 +0800
[Fix][Zeta] Remove obsolete checkpoint overview storage benchmark (#13255)
---
.../benchmark/CheckpointStorageBenchmark.java | 27 +------
.../CheckpointOverviewBenchmarkWorkload.java | 93 ----------------------
.../CheckpointPersistenceBenchmarkWorkload.java | 7 +-
.../CheckpointStorageBenchmarkFixture.java | 18 +----
4 files changed, 10 insertions(+), 135 deletions(-)
diff --git
a/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/CheckpointStorageBenchmark.java
b/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/CheckpointStorageBenchmark.java
index dfb6fa2033..c001c2ca89 100644
---
a/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/CheckpointStorageBenchmark.java
+++
b/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/CheckpointStorageBenchmark.java
@@ -18,7 +18,6 @@
package org.apache.seatunnel.benchmark;
import
org.apache.seatunnel.benchmark.storage.checkpoint.CheckpointIdIncrementBenchmarkWorkload;
-import
org.apache.seatunnel.benchmark.storage.checkpoint.CheckpointOverviewBenchmarkWorkload;
import
org.apache.seatunnel.benchmark.storage.checkpoint.CheckpointPersistenceBenchmarkWorkload;
import org.openjdk.jmh.annotations.Benchmark;
@@ -70,9 +69,10 @@ public class CheckpointStorageBenchmark extends
BenchmarkBase {
* <p>Each measured invocation processes 100 independent,
coordinator-produced checkpoints. For
* every checkpoint it atomically allocates the next checkpoint ID,
serializes and writes the
* completed checkpoint through the HDFS storage plugin, and updates the
checkpoint overview
- * through {@code CheckpointMonitorService}. Barrier delivery, task
snapshots, and ACK waiting
- * are intentionally excluded; fixture preparation, durability validation,
and cleanup run
- * outside measured time.
+ * through {@code CheckpointMonitorService}. The overview is observability
state kept in memory;
+ * only checkpoint IDs and checkpoint payloads are checked for durability.
Barrier delivery,
+ * task snapshots, and ACK waiting are intentionally excluded; fixture
preparation, result
+ * validation, and cleanup run outside measured time.
*
* <p>{@link Mode#SingleShotTime} executes exactly one fixed-size phase
per measurement
* iteration. {@link OperationsPerInvocation} then normalizes the phase
duration to one logical
@@ -102,23 +102,4 @@ public class CheckpointStorageBenchmark extends
BenchmarkBase {
throws Exception {
return workload.incrementCheckpointId();
}
-
- /**
- * Measures the completed-checkpoint update path of the production
checkpoint monitor.
- *
- * <p>For each of 100 independent checkpoint fixtures, the timed phase
calculates retained state
- * size and calls {@code
CheckpointMonitorService.onCheckpointCompleted()}. This exercises the
- * checkpoint-overview IMap update that increments the completed count and
records the latest
- * and historical checkpoint metadata. Fixture construction, durable
MapStore reload checks, and
- * cleanup are outside measured time.
- *
- * <p>{@link Mode#SingleShotTime} executes one fixed update phase per
measurement iteration, and
- * {@link OperationsPerInvocation} normalizes its duration to one
completed-checkpoint overview
- * update.
- */
- @Benchmark
- @OperationsPerInvocation(CHECKPOINT_OPERATIONS_PER_INVOCATION)
- public void
checkpointOverviewIncrementalUpdate(CheckpointOverviewBenchmarkWorkload
workload) {
- workload.updateCheckpointOverview();
- }
}
diff --git
a/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/storage/checkpoint/CheckpointOverviewBenchmarkWorkload.java
b/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/storage/checkpoint/CheckpointOverviewBenchmarkWorkload.java
deleted file mode 100644
index 34c37073dc..0000000000
---
a/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/storage/checkpoint/CheckpointOverviewBenchmarkWorkload.java
+++ /dev/null
@@ -1,93 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.seatunnel.benchmark.storage.checkpoint;
-
-import org.apache.seatunnel.engine.server.checkpoint.CompletedCheckpoint;
-
-import org.openjdk.jmh.annotations.Level;
-import org.openjdk.jmh.annotations.Scope;
-import org.openjdk.jmh.annotations.Setup;
-import org.openjdk.jmh.annotations.State;
-import org.openjdk.jmh.annotations.TearDown;
-
-import static
org.apache.seatunnel.benchmark.storage.checkpoint.CheckpointStorageBenchmarkFixture.CHECKPOINT_OPERATIONS_PER_INVOCATION;
-import static
org.apache.seatunnel.benchmark.storage.checkpoint.CheckpointStorageBenchmarkFixture.CheckpointOperation;
-
-/** Executes and verifies completed-checkpoint overview updates. */
-@State(Scope.Thread)
-public class CheckpointOverviewBenchmarkWorkload {
-
- private CheckpointStorageBenchmarkFixture fixture;
- private CheckpointOperation[] operations;
- private CompletedCheckpoint[] completedCheckpoints;
- private int preparedOperationCount;
- private boolean invoked;
-
- @Setup(Level.Trial)
- public void setUp(CheckpointStorageBenchmarkFixture fixture) {
- this.fixture = fixture;
- }
-
- @Setup(Level.Iteration)
- public void prepareIteration() throws Exception {
- invoked = false;
- preparedOperationCount = 0;
- operations = fixture.createOperations();
- completedCheckpoints = new
CompletedCheckpoint[CHECKPOINT_OPERATIONS_PER_INVOCATION];
-
- for (int index = 0; index < CHECKPOINT_OPERATIONS_PER_INVOCATION;
index++) {
- preparedOperationCount = index + 1;
- fixture.prepareOverview(operations[index]);
- completedCheckpoints[index] =
fixture.createCompletedCheckpoint(operations[index]);
- }
- }
-
- public void updateCheckpointOverview() {
- invoked = true;
- for (CompletedCheckpoint completedCheckpoint : completedCheckpoints) {
- fixture.updateOverview(completedCheckpoint);
- }
- }
-
- @TearDown(Level.Iteration)
- public void validateAndCleanIteration() {
- try {
- requireCompletedInvocation();
- fixture.reloadOverviewSamples(operations);
- for (CheckpointOperation operation : operations) {
- fixture.validateOverview(operation);
- }
- } finally {
- for (int index = 0; index < preparedOperationCount; index++) {
- fixture.removeOverview(operations[index]);
- }
- preparedOperationCount = 0;
- invoked = false;
- }
- }
-
- private void requireCompletedInvocation() {
- if (!invoked) {
- throw new IllegalStateException(
- "No checkpoint overview benchmark operation was recorded");
- }
- if (preparedOperationCount != CHECKPOINT_OPERATIONS_PER_INVOCATION) {
- throw new IllegalStateException("Checkpoint overview phase was not
fully prepared");
- }
- }
-}
diff --git
a/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/storage/checkpoint/CheckpointPersistenceBenchmarkWorkload.java
b/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/storage/checkpoint/CheckpointPersistenceBenchmarkWorkload.java
index 8aaa7835d2..2e29cd07a3 100644
---
a/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/storage/checkpoint/CheckpointPersistenceBenchmarkWorkload.java
+++
b/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/storage/checkpoint/CheckpointPersistenceBenchmarkWorkload.java
@@ -77,13 +77,16 @@ public class CheckpointPersistenceBenchmarkWorkload {
}
}
- /** Validates all three durable effects outside measured time, then
removes the fixed phase. */
+ /**
+ * Validates durable checkpoint state and the overview kept in memory
outside measured time,
+ * then removes the fixed phase.
+ */
@TearDown(Level.Iteration)
public void validateAndCleanIteration() throws Exception {
try {
requireCompletedInvocation();
fixture.reloadCounterSamples(operations);
- fixture.reloadOverviewSamples(operations);
+ // Checkpoint overviews are not persisted, so validate them
without evicting them.
for (int index = 0; index < CHECKPOINT_OPERATIONS_PER_INVOCATION;
index++) {
fixture.validateCounter(operations[index],
allocatedCheckpointIds[index]);
fixture.validateStoredCheckpoint(operations[index]);
diff --git
a/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/storage/checkpoint/CheckpointStorageBenchmarkFixture.java
b/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/storage/checkpoint/CheckpointStorageBenchmarkFixture.java
index 96b289b4ed..0dcec128d5 100644
---
a/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/storage/checkpoint/CheckpointStorageBenchmarkFixture.java
+++
b/seatunnel-benchmarks/src/main/java/org/apache/seatunnel/benchmark/storage/checkpoint/CheckpointStorageBenchmarkFixture.java
@@ -76,7 +76,6 @@ public class CheckpointStorageBenchmarkFixture {
private CheckpointOverviewStateStore overviewStore;
private CheckpointMonitorService monitorService;
private IMap<String, Long> checkpointCounterMap;
- private IMap<Long, CheckpointOverview> checkpointOverviewMap;
private long expectedCompletedCount;
@Setup(Level.Trial)
@@ -120,12 +119,6 @@ public class CheckpointStorageBenchmarkFixture {
.getNodeEngine()
.getHazelcastInstance()
.getMap(EngineStateStoreNames.CHECKPOINT_ID);
- checkpointOverviewMap =
- environment
- .getServer()
- .getNodeEngine()
- .getHazelcastInstance()
- .getMap(EngineStateStoreNames.CHECKPOINT_MONITOR);
} catch (Exception setupFailure) {
try {
tearDown();
@@ -198,15 +191,6 @@ public class CheckpointStorageBenchmarkFixture {
checkpointCounterMap.loadAll(keys, true);
}
- void reloadOverviewSamples(CheckpointOperation[] operations) {
- Set<Long> keys = new LinkedHashSet<>();
- for (int index : DURABILITY_SAMPLE_INDEXES) {
- keys.add(operations[index].jobId);
- checkpointOverviewMap.evict(operations[index].jobId);
- }
- checkpointOverviewMap.loadAll(keys, true);
- }
-
void validateCounter(CheckpointOperation operation, long
allocatedCheckpointId) {
if (allocatedCheckpointId != operation.checkpointId) {
throw new IllegalStateException(
@@ -257,7 +241,7 @@ public class CheckpointStorageBenchmarkFixture {
CheckpointOverview storedOverview = overviewStore.get(operation.jobId);
if (storedOverview == null || storedOverview.getJobId() !=
operation.jobId) {
throw new IllegalStateException(
- "Checkpoint overview was not stored for job " +
operation.jobId);
+ "Checkpoint overview is unavailable for job " +
operation.jobId);
}
PipelineCheckpointOverview pipelineOverview =