chovy-3012 opened a new pull request, #13257:
URL: https://github.com/apache/seatunnel/pull/13257

   ### Purpose of this pull request
   
   Make the Doris source `case_sensitive` option take effect in single-table 
mode (`database` + `table`). Fixes #13254. This is the follow-up of the 
case-sensitivity observation raised in the review of #13172.
   
   Previously the single-table branch of `DorisTableConfig#of` applied the 
lowercasing to a throw-away intermediate object while the returned config was 
built from the raw option values, so `case_sensitive = false` never took 
effect. The conversion now applies to the returned config, using 
`toLowerCase(Locale.ROOT)`; the option is also declared in 
`DorisSourceFactory#optionRule` and documented in the EN/ZH source docs.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. With `case_sensitive = false`, mixed-case identifiers are now 
lowercased before use (`TestDB.TestTable` → `testdb.testtable`); previously the 
option was silently ignored. Defaults (`true` / absent) are unchanged, so no 
valid config changes behavior.
   
   ### How was this patch tested?
   
   Added 3 regression cases to `DorisTableConfigTest` (single-table mode: 
`false` lowercases, `true` / absent keep the original case).
   
   ```
   ./mvnw test -pl seatunnel-connectors-v2/connector-doris
   # 163/163 pass (160 before + 3 new)
   
   ./mvnw spotless:check -pl seatunnel-connectors-v2/connector-doris
   # pass
   ```
   
   Negative control: restoring the previous implementation makes exactly the 
`false` case fail (`expected: <testdb.testtable> but was: <TestDB.TestTable>`).
   
   ### Check list
   
   * [x] If any new Jar binary package adding in your PR, please add License 
Notice according [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
 — no new jar/dependency added
   * [x] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs — EN/ZH source 
`Doris.md` option row added, with the single-table scope noted
   * [x] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR. — not needed: the option previously had no 
effect; defaults unchanged
   * [ ] If you are contributing the connector code, please check that the 
following files are updated — existing connector modified, no new connector 
added (plugin-mapping.properties / seatunnel-dist pom / label-scope-conf / 
plugin_config unchanged); no new e2e testcase added — covered by the 3 unit 
regression cases above
     1. Update 
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
 and add new connector information in it
     2. Update the pom file of 
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in 
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in 
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector 
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to